[PATCH] FUSE: nfsd with direct_io fix

From: Miklos Szeredi
Date: Sun Apr 24 2005 - 10:44:15 EST

This patch fixes an Oops which happens when a filesystem mounted with
the "direct_io" mount option is exported through NFS. The problem is
that nfsd passes a kernel buffer with the "set_fs(KERNEL_DS)" method
to read and write, but get_user_pages() won't work on such a buffer.
The current fix is "don't do that then". Long term solution will be
to implement nfs serving in userspace. Bug spotted by David Shaw.

Signed-off-by: Miklos Szeredi <miklos@xxxxxxxxxx>

diff -rup linux-2.6.12-rc2-mm3/fs/fuse/file.c linux-fuse/fs/fuse/file.c
--- linux-2.6.12-rc2-mm3/fs/fuse/file.c 2005-04-22 16:00:19.000000000 +0200
+++ linux-fuse/fs/fuse/file.c 2005-04-22 15:50:32.000000000 +0200
@@ -409,6 +409,10 @@ static int fuse_get_user_pages(struct fu
unsigned offset = user_addr & ~PAGE_MASK;
int npages;

+ /* This doesn't work with nfsd */
+ if (!current->mm)
+ return -EPERM;
nbytes = min(nbytes, (unsigned) FUSE_MAX_PAGES_PER_REQ << PAGE_SHIFT);
npages = (nbytes + offset + PAGE_SIZE - 1) >> PAGE_SHIFT;
npages = min(npages, FUSE_MAX_PAGES_PER_REQ);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/