Here 's a version of my fs/cifs/file.c cleanup patch split into seven chunks for easier review.I have reviewed and applied the first two, and also reviewed the get_disposition patch (which is also fine). I will review the others this weekend. Good work - thanks.
Please use these incremental patches instead of the big one I send you earlier since I've made a few changes compared to that.
For your convenience the patches are also available online at :
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-whitespace-changes.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-kfree-changes.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_init_private.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_open_inode_helper.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_convert_flags.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_get_disposition.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-condense_if_else.patch
(listed in the order they apply)
I still haven't managed to get hold of/setup a cifs server to test these against, so they are still only compile tested.I did some testing of this against Samba server last night.