Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups
From: Keir Fraser
Date: Wed Mar 16 2005 - 14:10:33 EST
On 16 Mar 2005, at 18:42, Jesse Barnes wrote:
The AGP driver is only configurable for ppc32, alpha, x86, x86_64 and
ia64, all of which have virt_to_bus.
Yeah, but that doesn't mean it makes sense on all those platforms. The
biggest problem with virt_to_bus (well, depending on who you talk to)
is that
it can't handle systems where the address translation must be done
differently depending on *which* bus we're getting a bus address for.
Not
sure what makes sense in this case though... is the DMA mapping
interface
appropriate?
I think that makes sense. How much code refactoring is needed to make
use of it, though?
Certainly it will work for Xen and it sounds better than
virt_to_bus/bus_to_virt, if someone will cook up the alternative patch.
Otherwise, virt_to_bus seems better than the status quo. :-)
-- Keir
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/