Re: [PATCH] blockdev: fix for racing mount/umount

[Al Viro]

On Tue, Mar 15, 2005 at 08:00:52AM -0800, Linus Torvalds wrote:
> 
> 
> On Tue, 15 Mar 2005, Jeff Mahoney wrote:
> >
> > This patch is another take at fixing the race between mount and umount
> > resetting the blocksize and causing buffer errors, infinite loops in
> > __getblk_slow, and possibly other undiscovered effects.
> 
> Ok. I had to go back and look up the original problem, and having looked 
> at this a bit more, I wonder whether the real problem is not that we do 
> that silly "set blocksize back to the original one" at umount time in the 
> first place.
> 
> (It happens very indirectly, though the "->kill_sb()" fn pointer, which 
> ends up doing kill_block_super on a regular block device).
> 
> Maybe we should just get rid of it entirely? There's really no point to 
> it.
> 
> Instead, to make things repeatable, we'd always just set the blocksize to
> its default value at the first open. We already do that anyway, don't we?

Yes, but we could explicitly change it at some point before mount.  I'm looking
through that stuff right now - been net.dead for several weeks, thanks to
fscking telco idiocy at exactly wrong time ;-/

Give me a couple of days, OK?  Three weeks of l-k is a hell of a backlog ;-/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/