Re: [PATCH] Possible VIA-Rhine free irq issue

[Jeff Garzik]

Panagiotis Issaris wrote:
> Hi,
>
> It seems to me that in the VIA Rhine device driver the requested irq might
> not be freed in case the alloc_ring() function fails. alloc_ring()
> can fail with a ENOMEM return value because of possible
> pci_alloc_consistent() failures.
>
> This patch applies to 2.6.11-rc5-bk2.
>
> diff -uprN linux-2.6.11-rc5-bk2/drivers/net/via-rhine.c linux-2.6.11-rc5-bk2-pi/drivers/net/via-rhine.c
> --- linux-2.6.11-rc5-bk2/drivers/net/via-rhine.c	2005-02-28 13:44:37.000000000 +0100
> +++ linux-2.6.11-rc5-bk2-pi/drivers/net/via-rhine.c	2005-02-28 13:44:31.000000000 +0100
> @@ -1198,7 +1198,10 @@ static int rhine_open(struct net_device 
>  
>  	rc = alloc_ring(dev);
>  	if (rc)
> +	{
> +		free_irq(rp->pdev->irq, dev);
>  		return rc;
> +	}

Yes, this is a needed fix.  Thanks,

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/