Re: [BK PATCHES] 2.6.x libata fixes (mostly)
From: Prakash Punnoor
Date: Wed Feb 23 2005 - 16:33:53 EST
Alexey Dobriyan schrieb:
> On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
>>+ addr = sg_dma_address(sg);
>>+ *(u64 *)prd = cpu_to_le64(addr);
>
>
> *(__le64 *) prd
>
>
>>+ prd += sizeof(u64);
>
>
>>+ len = sg_dma_len(sg);
>>+ *(u32 *)prd = cpu_to_le32(len);
>
>
> *(__le32 *) prd
If I am not totally mistaken this is not gcc4 friendly code. (lvalue thing...)
Wouldn't it be better to prevent double patching?
--
Prakash Punnoor
formerly known as Prakash K. Cheemplavam
Attachment:
signature.asc
Description: OpenPGP digital signature