Re: [PATCH] Re: msdos/vfat defaults are annoying

[Pozsár Balázs]

On Mon, Feb 07, 2005 at 02:48:00AM +0000, Nuno Monteiro wrote:
> 
> On 2005.02.07 00:42, Pozsár Balázs wrote:
> >On Mon, Feb 07, 2005 at 12:36:10AM +0000, Al Viro wrote:
> >> On Mon, Feb 07, 2005 at 12:21:08AM +0100, Pozsar Balazs wrote:
> >> > On Sun, Feb 06, 2005 at 07:06:59AM +0000, Christoph Hellwig wrote:
> >> > > filesystem detection isn't handled at the kerne level.
>        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> But since filesystem detection isn't handled in the kernel, changing the  
> link order is pointless. Please fix your /etc/filesystems instead.

But the contents of /proc/filesystems comes from the kernel. And the 
order of filesystems comes from the link order.

Let me show you, why it is _not_ pointless:
If you do not have /etc/filesystems, mount will read /proc/filesystems:

# strace -o mount.trace mount -t auto /dev/sda1 /mnt
# grep filesystems mount.trace
open("/etc/filesystems", O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory)
open("/proc/filesystems", O_RDONLY|O_LARGEFILE) = 3
# grep ^mount mount.trace
mount("/dev/sda1", "/mnt", "squashfs", 0xc0ed0000, 0) = -1 EINVAL (Invalid argument)
mount("/dev/sda1", "/mnt", "vfat", 0xc0ed0000, 0) = 0

See? I _have_ that patch applied, that's why it tried vfat and not msdos 
first.

Granted, I could override the default order by using a /etc/filesystems 
file. But the kernel should have a much more sane default on its own, 
namely "try vfat before msdos".



-- 
pozsy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/