Re: i386 HPET code

From: Andi Kleen
Date: Thu Feb 03 2005 - 16:31:30 EST


> Basically I am thinking of something like this will be a good generic solution
> in place of simple two writes.
>
> for (i = 0 ; i <some number for max retries>; i++) {
> hpet_writel(hpet_tick, HPET_T0_CMP);
> if (hpet_tick == hpet_readl(hpet_tick, HPET_T0_CMP))
> break;
> }

Makes sense. There were so many bugs in PIT timer access over time,
it would be probably a miracle if the hardware engineers got all
the HPET implementations right ;-)

If you do a fix like this please change x86-64 too.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/