Re: [patch libata-dev-2.6 1/1] libata: sync SMART ioctls with ATApass thru spec (T10/04-262r7)

[Douglas Gilbert]

Jens Axboe wrote:
<snip>
> >
> > -/* Temporary values for T10/04-262 until official values are
> allocated */
> > -#define	ATA_16		      0x85	/* 16-byte pass-thru
> [0x85 == unused]*/
> -#define	ATA_12		      0xb3	/* 12-byte pass-thru
> [0xb3 == obsolete set limits command] */
> > +/* Values for T10/04-262r7 */
> > +#define	ATA_16		      0x85	/* 16-byte pass-thru */
> > +#define	ATA_12		      0xa1	/* 12-byte pass-thru */
>
> Ehh are you sure that is correct? 0xa1 is the BLANK command, I would
> hate to think there would be a collision like that.

That very point came up recently in a MMC meeting:
http://www.t10.org/ftp/t10/document.05/05-056r0.pdf

To confuse things further "ATA_16" is shown as opcode 0x98
in the latest draft of SPC-3 (rev 21c 15 January 2005)
http://www.t10.org/ftp/t10/drafts/spc3/spc3r21c.pdf [annex D.3.1].

Hopefully these matters will be sorted out at the next t10
meeting in March.

Doug Gilbert

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/