RE: [Announce] megaraid_mbox 2.20.4.4 patch

[James Bottomley]

On Wed, 2005-02-02 at 10:56 -0500, Ju, Seokmann wrote:
> +	.sdev_attrs			= megaraid_device_attrs,
> +	.shost_attrs			= megaraid_class_device_attrs,

These are, perhaps, slightly confusing names.  The terms device and
class_device have well defined meanings in the generic device model,
neither of which is what you mean here.  Why not simply
megaraid_sdev_attrs and megaraid_shost_attrs?

Other than this, it looks fine to me too.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/