Re: [PATCH] Altix : ioc4 serial driver support

From: Bartlomiej Zolnierkiewicz
Date: Wed Feb 02 2005 - 16:51:08 EST


On Wed, 02 Feb 2005 14:36:15 -0600, Patrick Gefre <pfg@xxxxxxx> wrote:
> Christoph Hellwig wrote:
> > Do you need to use ide_pci_register_driver? IOC4 doesn't have the legacy
> > IDE problems, and it's never used together with such devices in a system,
> > so a plain pci_register_driver should do it.
> >
>
> So ide_pci_register_driver is only for legacy devices with certain IDE
> problems - I think that is what you are saying (just trying to make sure
> I have it right) ??

ide_pci_register() is needed because of legacy ordering assumptions
(from BIOS and/or Windows) in case of many PCI IDE devices. If there
is no possibility of other IDE PCI devices on your architecture it is safe to
call pci_register_driver() directly (see ide_scan_pcibus() in setup-pci.c).

BTW IDE part of the patch looks OK.

Thanks,
Bartlomiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/