Re: [2.6 patch] mark the mcd cdrom driver as BROKEN

[Bill Davidsen]

Adrian Bunk wrote:
> On Sat, Jan 29, 2005 at 06:22:55PM +0100, Jean Delvare wrote:
>
> > Hi Adrian,
> >
> >
> > > The mcd driver drives only very old hardware (some single and double 
> > > speed CD drives that were connected either via the soundcard or a 
> > > special ISA card), and the mcdx driver offers more functionality for
> > > the  same hardware.
> > >
> > > My plan is to mark MCD as broken in 2.6.11 and if noone complains 
> > > completely remove this driver some time later.
> > > (...)
> > > -	depends on CD_NO_IDESCSI
> > > +	depends on CD_NO_IDESCSI && BROKEN
> >
> > Shouldn't we introduce a DEPRECATED option for use in cases like this
> > one?
>
>
> We could.
>
> We could also list MCD in Documentation/feature-removal-schedule.txt 
> first.
>
> But in this case I doubt it makes any difference.
>
> This driver is for hardware where I doubt many users exist today, and it 
> should have been removed nearly ten years ago when the better mcdx 
> driver for the same now-obsolete hardware entered the kernel.

I actually have one (or two) of these, but I agree that in this case it 
makes no difference. As a general thing I think DEPRECIATED would be 
useful for the case where there is a newer functional driver. The 
systems I have are unlikely to ever run a current kernel, so I am not 
affected, and I suspect most others who have this old stuff are running 
2.0 or 2.2 kernels, also.

--
   -bill davidsen (davidsen@xxxxxxx)
"The secret to procrastination is to put things off until the
 last possible moment - but no longer"  -me
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/