Re: [2.6 patch] DRM: misc cleanup

[Dave Airlie]

On Mon, 31 Jan 2005 01:36:50 +0100, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> This patch contains the following cleanups:
> - make needlessly global functions static
> - remove the following unused global functions:
>   - drm_fops.c: drm_read
>   - i810_dma.c: i810_do_cleanup_pageflip
>   - i830_dma.c: i830_do_cleanup_pageflip
>   - i915_dma.c: i915_do_cleanup_pageflip
>   - mga_dma.c: mga_do_dma_idle
>   - mga_dma.c: mga_do_engine_reset
>   - radeon_irq.c: radeon_emit_and_wait_irq
>   - sis_ds.c: mmAddRange
>   - sis_ds.c: mmReserveMem
>   - sis_ds.c: mmFreeReserved
>   - sis_ds.c: mmDestroy
>   - via_ds.c: via_mmDumpMemInfo
>   - via_ds.c: via_mmAddRange
>   - via_ds.c: via_mmReserveMem
>   - via_ds.c: via_mmFreeReserved
>   - via_ds.c: via_mmDestroy
> - remove the followig unused global variable:
>   - via_mm.c: VIA_DEBUG

I'll nack this patch for now Adrian, but I'm going to bring all these
changes into the DRM tree as soon as I can.. one of the functions you
removed pointed out a bug in the i810/i830/i915 drivers (granted
no-one uses pageflip in those drivers but still should fix it..), I'm
going to put the through drm CVS first...

Thanks,
Dave.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/