Re: 2.6.11-rc2-mm1: SuperIO scx200 breakage
From: Evgeniy Polyakov
Date: Thu Jan 27 2005 - 06:50:29 EST
On Thu, 2005-01-27 at 11:20 +0100, Adrian Bunk wrote:
> On Wed, Jan 26, 2005 at 10:27:43PM +0300, Evgeniy Polyakov wrote:
> >...
> > I greatly appreciate your comments, and they were addressed.
> > Part of exported symbols are unexported, patch is just waiting to be sent,
>
> Ah, sorry. I only saw that the patch I sent two months ago still
> applies completely (except for an unrelated context change).
Patch is alredy sent, but probably it will not apper in the nearest -mm
release.
> > but I do not agree with dscore rename. I just do not understand it's advantage.
>
> It is only a small cosmetic thing:
> If there's only one object file in a module, a renaming in the Makefile
> is superfluous - you can simply rename the source file
Most of it's exports are preparation for EEPROM driver, which will
require
some changes in w1 core(it needs to export additional callbacks).
I'm currently review DS device set to find any dependency upon ds2490
chip -
but it looks like there is no one, so it is alredy not core, but device
driver
itlself.
I'm not too religious about it's name...
> cu
> Adrian
>
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
Attachment:
signature.asc
Description: This is a digitally signed message part