Re: [PATCH] use mmiowb in via-rhine

[Dave Jones]

On Wed, Jan 19, 2005 at 12:22:20PM -0800, Matt Mackall wrote:
 > Use the generic PCI memory barrier. Test-compiled.

This can't be right.

 > Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>
 > 
 > Index: bk/drivers/net/via-rhine.c
 > ===================================================================
 > --- bk.orig/drivers/net/via-rhine.c	2005-01-19 12:06:52.283455936 -0800
 > +++ bk/drivers/net/via-rhine.c	2005-01-19 12:18:02.536561976 -0800
 > @@ -351,9 +351,6 @@
 >   * indicator. In addition, Tx and Rx buffers need to 4 byte aligned.
 >   */
 >  
 > -/* Beware of PCI posted writes */
 > -#define IOSYNC	do { ioread8(ioaddr + StationAddr); } while (0)
 > -

You're replacing a PCI ordering barrier with..

include/asm-i386/io.h:#define mmiowb()

nothing ?

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/