Re: [PATCH] Support compat_ioctl for block devices

[Christoph Hellwig]

> +long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
> +{
> +	struct block_device *bdev = file->f_dentry->d_inode->i_bdev;
> +	struct gendisk *disk = bdev->bd_disk;
> +	int ret = -ENOIOCTLCMD;
> +	if (disk->fops->compat_ioctl) {
> +		lock_kernel();
> +		ret = disk->fops->compat_ioctl(file, cmd, arg);
> +		unlock_kernel();
> +	}
> +	return ret;
> +}

 - please don't introduce a new API with the BKL held.
 - prototype isn't nice.  just passing the gendisk for block_device
   should be enough.

also this wants documentation in Documentation/filesystems/Locking
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/