Re: 2.6.10-mm3: swsusp: out of memory on resume (was: Re: Ho ho ho - Linux v2.6.10)

[Rafael J. Wysocki]

On Sunday, 16 of January 2005 15:46, hugang@xxxxxxxxxxxx wrote:
> On Sun, Jan 16, 2005 at 11:07:24AM +0100, Rafael J. Wysocki wrote:
> > > 
> > > I disable Flush TLB after copy page, It speedup the in qemu, But I can't
> > > sure the right thing in real machine, can someone give me point.
> > 
> > Could you, please, make a patch against -rc1-mm1 with your previous patch
> > applied?  It would be much easier to apply. :-)
> > 
> 
> http://soulinfo.com/~hugang/swsusp/2005-1-16/

Actually, there's a bug in your code: in swsusp.c:alloc_one_pagedir() you
should return NULL rather than -ENOMEM.

Greets,
RJW


-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/