Re: [PATCH] kill symbol_get & friends

[Rusty Russell]

On Thu, 2005-01-13 at 18:05 +0100, Christoph Hellwig wrote:
> On Thu, Jan 13, 2005 at 11:19:33AM +1100, Rusty Russell wrote:
> > If you don't hold a reference, then yes, the module can go away.  This
> > hasn't been a huge problem for users in the past.
> 
> There's a single users, and it has these problems.

It is an excellent candidate for weak symbols though.  If you want the
symbols to stay around, of course you have to keep a reference to them.
This code seems silly to me.

> > The lack of users is because, firstly, dynamic dependencies are less
> > common than static ones, and secondly because the remaining inter-module
> > users (AGP and mtd) have not been converted.
> 
> AGP doesn't use dynamic symbols anymore, only mtd is gone.  And I'd
> rather see it not switching to symbol_get.

If it really wants dynamic symbol lookup, that's damn well what's going
to happen.  intermodule must die.  If David doesn't want that feature
any more, then sure, remove it.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/