Re: [PATCH] release_pcibus_dev() crash

[Greg KH]

On Thu, Jan 13, 2005 at 03:17:58PM -0600, John Rose wrote:
> > Closer (you forgot a changelog entry too...)
> 
> Just to be a brat, I'll point out that I couldn't find a single user of
> CLASS_DEVICE_ATTR that explicitly cleans things up like we're doing here.  That
> would include firmware and net-sysfs stuff.  Maybe enforcing such a policy upon
> device removal would increase participation :)  But okay, here's another try:

Yeah, I know everyone doesn't do it, but I'm trying to get them all to,
and when I have a chance to point it out and fix it, I am.  Just like
now, thanks for putting up with me :)

> During the course of a hotplug removal of a PCI bus, release_pcibus_dev()
> attempts to remove attribute files from a kobject directory that no longer
> exists.  This patch moves these calls to pci_remove_bus(), where they can work
> as intended.
> 
> Signed-off-by: John Rose <johnrose@xxxxxxxxxxxxxx>

Looks good, applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/