Re: [PATCH]change 'struct device' -> platform_data to firmware_data

From: Li Shaohua
Date: Wed Jan 12 2005 - 00:26:47 EST


On Wed, 2005-01-12 at 13:06, Greg KH wrote:
>
> > If we are doing things incorrectly, I am not argueing that our usage
> > has to the way it sits. We could create a new generic serial_device and
> > flash_device structures and subsystems for these, but that requires
> > rewriting drivers and board ports; however, we need enough time
> > to work with appropriate subsystem maintainers to do so. My suggestion
> > is to add a new firmware_data field for use by ACPI ATM while we
> > clean things up in ARM world if so required. Since ACPI is non-existent
> > on ARM systems, another option is that we keep using the renamed data
> > structure as we have been doing. /me votes for this option
>
> I like the "just add a firmware_data" field option too. It doesn't
> break any existing code, and the term "firmware" tells driver authors to
> back away from it and not touch it (and we need to add the proper
> documentation saying this.)
If nobody insists on the intent of platform_data, I'll be glad to add a
new field. It makes things more easy.

Thanks,
Shaohua

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/