Re: Screwy clock after apm suspend

From: Mikael Pettersson
Date: Tue Jan 11 2005 - 09:16:46 EST


Pavel Machek writes:
> Hia
>
> > > Looking harder, in arch/i386/kernel/apm.c the system time is also
> > > saved and restored in a very similar way to timer_suspend/resume.
> > > Would this account for the time drift in APM mode? (sleep time being
> > > accounted for twice?)
> >
> > No, apm.c's update to xtime is absolute, just like time.c's.
> > Doing both is pointless but not harmful. (I've already tried
> > with apm.c's xtime update commented out, but the time-warp
> > bug remained.)
> >
> > My 0.02 SEK says it's the jiffies update that's broken.
>
> Okay, can you
>
> * kill jiffie update (x86-64, too)
> * remove apm.c variant
> * test it (or make someone test it) with apm?
>
> I now see the drift with acpi, too :-(. I can do the acpi testing...

I'm away from my APM laptop until Friday, but I'll do this test then.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/