Re: [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c]

[Alan Cox]

On Sad, 2005-01-08 at 08:33, Paul Gortmaker wrote:
> Is it possible that skb_padto has since got its act together?   Reason I
> ask is that I just dusted off a crusty 386dx40 (doesn't get much older

Could be - kmalloc has probably improved but the skbuffs have got far
more complex

> than that) with a wd8013.  As a basic test, I did ttcp Tx tests with small
> packets and they came out to all intents and purposes, identical.   Kernel 
> was 2.6.10, with stack vs skb_padto, each size test ran 3 times, even tested
> packets bigger than ETH_ZLEN as a (hopefully) invariant.  I've attached the
> edited down results below.

What are you testing ? I don't see the relationship between network
throughput and efficiency on this device.

Drop it on a pentium or late 486 and use the tsc to compare the two code
paths. One is much much more efficienct.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/