Re: [PATCH] fs: Restore files_lock and set_fs_root exports

[Adrian Bunk]

On Fri, Jan 07, 2005 at 02:00:34PM -0800, Andrew Morton wrote:
> 
> No, I'd say that unexports are different.  They can clearly break existing
> code and so should only be undertaken with caution, and with lengthy notice
> if possible.
> 
> And it _is_ possible here, because there are no plans to change the
> exported functions, and it's only two lines of code, dammit.
> 
> The cost to us of maintaining those two lines of code for a year is
> basically zero.
> 
> The cost to others of us removing those two lines of code without warning
> is appreciable.
> 
> Obvious solution: don't remove the two lines of code without warning.
> 
> The only reason I can see for peremptorily removing those two lines of code
> is that there is some benefit to doing so which outweighs the downstream
> cost of doing so.  Nobody has demonstrated such a benefit.
>...

I did a bit research using grep, sort, uniq and wc:

between 2.6.9 and 2.6.10:
414 EXPORT_SYMBOL's were removed

since 2.6.10:
90 EXPORT_SYMBOL's were removed in Linus' tree

in 2.6.10-mm2 excluding linus.patch:
71 EXPORT_SYMBOL's are removed

Notes:
- EXPORT_SYMBOL_GPL's weren't counted in any way
- if an EXPORT_SYMBOL was moved, it wasn't counted (using uniq)
- small mistakes in the numbers might be possible since my method to
  measure them was't at a scientific level, but after a quick look
  it seems the numbers are roughly correct


Resurrecting and documenting all of these recently removed 
EXPORT_SYMBOL's because some company might have found some way to 
(ab)use one or more of them costs us:
- some extra work
- wasts space for all users of Linux (e.g. some of the recent removals
  are "remove EXPORT_SYMBOL'ed but completely unused function" patches
  I sent)


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/