Re: In last setsid/tty locking changes...

From: Alan Cox
Date: Fri Jan 07 2005 - 11:52:52 EST


On Gwe, 2005-01-07 at 13:37, Marco Cipullo wrote:
> In last setsid/tty locking changes:
> + down(&tty_sem);
> current->signal->tty = NULL;
> + up(&tty_sem);
>
> /* Block and flush all signals */
> sigfillset(&blocked);
>
> Sorry for the silly question, but why is needed a semaphore to write just one
> value without read/write nothing else?

Look at the tty init_dev code paths and it might make more sense. It
doesn't just say "protect this write" more importantly it says "don't do
this in parallel with tty setup"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/