Re: [2.6 patch] net/ipv6/: misc cleanups

[YOSHIFUJI Hideaki / 吉藤英明]

In article <20050107030017.GF14108@xxxxxxxxx> (at Fri, 7 Jan 2005 04:00:17 +0100), Adrian Bunk <bunk@xxxxxxxxx> says:

> - #if 0 the following unused global variable:
>   - addrconf.c: in6addr_any
> - remove the following EXPORT_SYMBOL's:
>   - ipv6_syms.c: in6addr_any
>   - ipv6_syms.c: in6addr_loopback
:
> --- linux-2.6.10-mm2-full/include/linux/in6.h.old	2005-01-07 02:34:21.000000000 +0100
> +++ linux-2.6.10-mm2-full/include/linux/in6.h	2005-01-07 02:36:18.000000000 +0100
> @@ -44,10 +44,10 @@
>   * NOTE: Be aware the IN6ADDR_* constants and in6addr_* externals are defined
>   * in network byte order, not in host byte order as are the IPv4 equivalents
>   */
> +#if 0
>  extern const struct in6_addr in6addr_any;
>  #define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } }
> -extern const struct in6_addr in6addr_loopback;
> -#define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }
> +#endif
>  

I meant:

#if 0
extern const struct in6_addr in6addr_any;
#define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } }
#endif
extern const struct in6_addr in6addr_loopback;
#define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }

And,

> @@ -191,7 +188,11 @@
>  };
>  
>  /* IPv6 Wildcard Address and Loopback Address defined by RFC2553 */
> +#if 0
> +#define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } }
>  const struct in6_addr in6addr_any = IN6ADDR_ANY_INIT;
> +#endif
> +#define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }
>  const struct in6_addr in6addr_loopback = IN6ADDR_LOOPBACK_INIT;
>  

#if 0
const struct in6_addr in6addr_any = IN6ADDR_ANY_INIT;
#endif
const struct in6_addr in6addr_loopback = IN6ADDR_LOOPBACK_INIT;

or something like this.

--yoshfuji


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/