Re: [PATCH] fs: Restore files_lock and set_fs_root exports

[Christoph Hellwig]

On Thu, Jan 06, 2005 at 03:26:21PM -0800, Andrew Morton wrote:
> 
> Guys, the technical arguments are all of course correct.  But the fact
> remains that we broke things without any notice.  (Yes, perhaps someone did
> say something at sometime, but the affected party didn't know, and it's our
> job to make sure that they knew).  (These exports were removed in October -
> the IBM guys need to work out why it took so long to detect the breakage).
> 
> I think the exports should be restored.  So does Linus ("Not that I like it
> all that much, but I don't think we should break existing modules unless we
> have a very specific reason to break just those modules.").

No.  I specificly asked the question how they're using it and they're use is

 a) completely buggy
 b) poking so deep in the kernel that the user falls under the GPL
    derived works clause.  As a copyright holder of quite a bit of fs/*.c
    I certainly wouldn't give IBM a special exception to use it even if
    it was exported.

These exports were only added for intermezzo during 2.4.x and with the
removal of intermezzo they go.  They never were a public API, and that they
were needed at all was a managment mistake in how that code was merged.

> Which begs the question "how do we ever get rid of these things when we
> have no projected date for Linux-2.8"?

We've been removing stuff that has

 (1) no intree users
 (2) doesn't make sense as API

there's simply no guarantee with out of tree users.  I've gotten quite a few
mails for the recent removals, and I could tell everyone a better way to
solve it.  Just as we did to IBM for this problem (very highlevel as they
don't show sources), but they insist on their completely broken way of doing
it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/