Re: [PATCH] support for gzipped (ELF) core dumps

[Miquel van Smoorenburg]

In article <1105017578.28175.1.camel@borcx178>,
Jan Frey  <jan.frey@xxxxxxxxx> wrote:
>I've written a patch for 2.4.28 kernel which enables writing of core
>dump files for ELF binaries in .gz format. This is interesting when
>using and debugging large binaries. In my case core files exceeded 1GB
>and got written via NFS...
>Anyhow, below patch is not really "beautiful", especially CRC looks
>quite annoying here.

>+/* This table is needed for efficient CRC32 calculation */
>+static const unsigned long crc_table[8][256] = {
>+	{
>+		0x00000000UL, 0x77073096UL, 0xee0e612cUL, 0x990951baUL, 0x076dc419UL,

You know, this looks exactly the same as lib/crc32table.h ...
I'd consider using lib/crc32.c.

Mike.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/