Re: 2.6.10-mm2

From: Christoph Hellwig
Date: Thu Jan 06 2005 - 05:49:15 EST


> +rio-cli-conversion.patch
> +rio_linux-64-bit-workaround.patch

RIO is totally broken on all plattforms, and rio-cli-conversion.patch
makes it even more broken with things like:

-#define disable(oldspl) save_flags (oldspl)
-#define restore(oldspl) restore_flags (oldspl)
+#define disable(oldspl) local_irq_save(oldspl);
+#define restore(oldspl) local_irq_restore(oldspl) ;

or

+ if (PortP->gs.flags & ASYNC_CLOSING){
+ interruptible_sleep_on(&PortP->gs.close_wait);
+ }

please drop rio-cli-conversion.patch and mark the driver BROKEN to wait
a little before finally removing it unless it'll get a major rewrite.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/