Re: [PATCH][5/?] count writeback pages in nr_scanned

[Andrew Morton]

Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
>  > If the queue is not congested, blk_congestion_wait() will still sleep.  See
>  > freed_request().
>  > 
> 
>  Hmm... doesn't look like it to me:
> 
>           if (rl->count[rw] < queue_congestion_off_threshold(q))
>                   clear_queue_congested(q, rw);
> 
>  And clear_queue_congested does an unconditional wakeup (if there
>  is someone sleeping on the congestion queue).

That's my point.  blk_congestion_wait() will always sleep, regardless of
the queue's congestion state.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/