Re: [PATCH /3] sh64: remove cli()/sti() from arch/sh64/*

From: Paul Mundt
Date: Wed Jan 05 2005 - 12:35:51 EST


On Tue, Jan 04, 2005 at 10:11:23PM -0500, Jim Nelson wrote:
> Everything I've looked at so far has been for single-processor systems
> AFAICT - embedded processors, evaluation boards, etc. I do not pretend
> to have intimate familiarity with the hardware in question, and I will
> be much more careful when I reach anything that can be plugged into an
> SMP box, but I was grabbing the low-hanging fruit first. The nasty
> stuff (drivers/char, for example) will come later.
>
> That's why I cc'd the arch maintainers - figured they'd whack me with a
> cluebat if I'd overlooked something.

Yes, these are all UP cases, so at least for the sh and sh64 cases these
specific changes are fine.

sh ripped out the save_and_cli() mess a long time ago (during early 2.5
before Linus added the UP compat stuff), so these at least shouldn't
have been there in the first place (mpc1211 wasn't added until after the
fact however and seems to have gotten overlooked).

Anyways, I'll apply these patches to their respective trees, thanks.

Attachment: pgp00000.pgp
Description: PGP signature