Re: [PATCH] deprecate (un)register_ioctl32_conversion

From: Christoph Hellwig
Date: Wed Jan 05 2005 - 11:11:34 EST


On Wed, Jan 05, 2005 at 04:19:16PM +0100, Andi Kleen wrote:
> Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:
>
> > On Wed, Jan 05, 2005 at 04:40:43PM +0200, Michael S. Tsirkin wrote:
> >> Hello, Andrew, all!
> >>
> >> Since in -mm1 we now have a race-free replacement (that being ioctl_compat),
> >> here is a patch to deprecate (un)register_ioctl32_conversion.
> >
> > Sorry, but this is a lot too early. Once there's a handfull users left
> > in _mainline_ you can start deprecating it (or better remove it completely).
>
> There were never more than a handful users of it anyways. So I think
> Michael's suggestion to deprecate it early is very reasonable.

It's 72 callers in mainline. Aka 72 new warnings for an allmodconfig
build. This isn't reasonable just because the interface got out of
fashion.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/