Re: Prezeroing V3 [4/4]: Driver for hardware zeroing on Altix

From: Andi Kleen
Date: Tue Jan 04 2005 - 21:18:54 EST


Christoph Lameter <clameter@xxxxxxx> writes:

> + /* Check limitations.
> + 1. System must be running (weird things happen during bootup)
> + 2. Size >64KB. Smaller requests cause too much bte traffic
> + */
> + if (len >= BTE_MAX_XFER || len < 60000 || system_state != SYSTEM_RUNNING)
> + return EINVAL;

surely return -EINVAL;

Also have you thought about doing a similar driver for x86/x86-64 using
cache bypassing stores?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/