Re: My vision of usbmon

[Greg KH]

On Tue, Dec 21, 2004 at 05:29:06PM -0800, Pete Zaitcev wrote:
> On Tue, 21 Dec 2004 16:57:26 -0800, Greg KH <greg@xxxxxxxxx> wrote:
> 
> > It looks great, thanks for doing this work.  Let me know when you want
> > it added to the kernel tree.
> 
> Thanks, Greg. There's a little tidbit in usbmon about which I wish you to
> make a pronouncement explicitly:
> 
> +	/* XXX Is this how I pin struct bus? Ask linux-usb-devel */
> +	kobject_get(&ubus->class_dev.kobj);
> +	mbus->u_bus = ubus;
> +	ubus->mon_bus = mbus;

Use usb_bus_get() instead.  Ick, that function's implementation sucks,
I'll go clean it up and export it for you to be able to use from your
code.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/