Re: [PATCH] add PCI API to sysfs

[Jesse Barnes]

On Monday, December 20, 2004 11:10 pm, Benjamin Herrenschmidt wrote:
> > > +static int mmap(struct file *file, struct vm_area_struct *vma)
> > > +{
>
> Also, just a style comment: I dislike when functions have such a
> "generic" name like mmap. I'd _much_ prefer something like pcisysfs_mmap
> or something like that. The simple name makes it confusing in
> System.map/kallsyms and thus when debugging.

True, but I was just following the convention in bin.c.  Maybe that could be 
cleaned up all at once with a separate patch?  There's some whitespace I'd 
like to cleanup in pci-sysfs.c as well, so I could do both at once.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/