Re: [Lse-tech] [RFC] fork historic module

From: Guillaume Thouvenin
Date: Mon Dec 20 2004 - 03:11:36 EST


On Fri, 2004-12-17 at 16:11 +0100, Andi Kleen wrote:
> > +/* IOCTL numbers */
> > +/* If you add a new IOCTL number don't forget to update FH_MAXNR */
> > +#define FH_MAGIC 0x35
> > +#define FH_REGISTER _IO(FH_MAGIC,0)
> > +#define FH_UNREGISTER _IO(FH_MAGIC,1)
>
> Is this really unique? 32bit emulation currently needs unique ioctl numbers.

I read the Documentation/ioctl-number.txt file and 0x35 is not mentioned
in this file. But I made a grep on 'MAGIC' and '35' in the Linux source
tree and you're right, this number is already used by POR_MAGIC_2.

Is a grep in the Linux source tree is enough to know if the value is
unique?

Thanks,
Guillaume

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/