Re: [PATCH]PCI Express Port Bus Driver

[Greg KH]

On Wed, Dec 15, 2004 at 04:06:44PM -0800, Nguyen, Tom L wrote:
> On Wednesday, December 15, 2004 1:37 PM, Greg KH wrote: 
> >> +config PCIEPORTBUS
> >> +	bool "PCI Express support"
> >> +	depends on PCI_GOMMCONFIG
> >
> > This should also work if PCI_GOANY is selected, right?  Otherwise this
> > feature will never be turned on by any distro :(
> PCIE port bus driver depends on PCI_GOMMCONFIG to locate service
> attributes for advanced error reporting (AER) and virtual channel (VC)
> for each PCIE port.  Without PCI_GOMMCONFIG, then a read to 0x100
> offset or above will return 0xffff; in other words, neither AER nor VC
> service support is found. We would like to move forward to have
> PCI_GOMMCONFIG dependency as the new features come along. RHEL 4 is
> shipping with PCI_GOMMCONFIG configured into the kernel by default and
> we expect the next major version of SuSE linux to do the same.

Hm, I get a oops message at boot time, on a non-pci express box, with
PCI_GOMMCONFIG enabled and your patch.  Something down in the ACPI
subsystem. 

Have you tested this kind of configuration?

I'll hold off on applying the patch for now due to this :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/