Re: [PATCH] 2.6.10 Altix : ioc4 serial driver support

[Patrick Gefre]

Christoph Hellwig wrote:
> On Thu, Dec 16, 2004 at 04:24:26PM -0600, Pat Gefre wrote:
>
> > I have a serial driver for Altix I'd like to submit.
> >
> > The code is at:
> > ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support
> >
> > Signed-off-by: Patrick Gefre <pfg@xxxxxxx>
>
>
> I took a very short look and what spring to mind first is that the
> device probing/remoal is rather bogus.  The ->probe/->remove callbacks
> of a PCI driver can be called at any time, and any initialization /
> teardown actions must happen from those.  A logical consequence of that
> is that a proper PCI driver should have no global state.

Christoph,

I'm not sure what you mean here. I don't have an entry for ->remove and the driver is self-contained.

-- Pat
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/