Re: [Lse-tech] [RFC] fork historic module

From: Andi Kleen
Date: Fri Dec 17 2004 - 12:01:33 EST


On Fri, Dec 17, 2004 at 05:52:38PM +0100, Manfred Spraul wrote:
> Andi wrote:
>
> >>+/* IOCTL numbers */
> >>+/* If you add a new IOCTL number don't forget to update FH_MAXNR */
> >>+#define FH_MAGIC 0x35
> >>+#define FH_REGISTER _IO(FH_MAGIC,0)
> >>+#define FH_UNREGISTER _IO(FH_MAGIC,1)
> >
> >Is this really unique? 32bit emulation currently needs unique ioctl
> >numbers.
> >
> >
> Are there plans to fix that? Perhaps move the emulation callback into
> struct file?

Yes. See the thread on l-k i started two days ago.

Actually the main reason is that the current conversion setup has a
unfixable module unload race.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/