Re: [PATCH 0/30] return statement cleanup - kill pointless parentheses

[Jesper Juhl]

Arnd Bergmann wrote:
> On Dunnersdag 16 Dezember 2004 01:02, Jesper Juhl wrote:
>
> > If these patches are generally acceted then I think it would make
>
> sense to 
>
> > make a small addition to Documentation/CodingStyle mentioning the
>
> prefered 
>
> > form of return statements, so we (hopefully) won't have to do cleanups
>
>
> > like this too often in the future.
> > Below I've included a proposed patch adding such a bit to CodingStyle.
>
> I think the change in Documentation/CodingStyle is useful, even though I
> don't really like changing all the existing code without going through
> the respective maintainers.
I guess you have a point. I won't submit more of these through LKML but 
will stick to working with maintainers.
These first 30 patches were mostly meant to "test the waters".

I'm glad you like the addition to CodingStyle. :)

> This is basically the same category as the first three chapters of
> CodingStyle. It's not nice to read, but there is no real problem in the 
> code. Think of these issues as whitespace fixes: you are making the job
> harder for code maintainers for very little gain. I would suggest that
> you submit these patches only to the code maintainers, not to the
> Trivial
> Patch Monkey or Andrew.

Will do.


> Or even better, change scripts/Lindent to do the change automatically
> for
> code that it is used on, if that can be done in a reliable way.
>  Arnd <><

I've never actually looked at how that script does its work, guess now's 
a good time to start looking :)


--
Jesper Juhl
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/