Re: [BK PATCH] SCSI -rc fixes for 2.6.10-rc3

From: Jens Axboe
Date: Sat Dec 11 2004 - 12:24:21 EST


On Sat, Dec 11 2004, James Bottomley wrote:
> On Fri, 2004-12-10 at 14:55 -0800, Randy.Dunlap wrote:
> > I have a drive, but I'm not near a highmem machine atm.
> > I can test it next week if no one else does so.
>
> So would you be amenable to fixing it properly? It looks like what
> needs to happen is that it needs to accept its commands into the
> scsi_pointer with page and offset (scsi_pointer doesn't have these
> fields, but you could probably cast in ptr and dma_handle). Then do a
> kmap/kunmap around imm_in() and imm_out() when it's operating on
> SCp.ptr.

Yep, that would be the optimal. But still, given the hardware, I feel
the hacky workaround would be acceptable. If Randy wants to fix it
properly being able to test it, perfect.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/