Re: [PATCH, RFC] protect call to set_tsk_need_resched() by the rq-lock

[Michael Buesch]

Quoting Ingo Molnar <mingo@xxxxxxx>:
> 
> * Michael Buesch <mbuesch@xxxxxxxxxx> wrote:
> 
> > The two attached patches (one against vanilla kernel and one against
> > ck patchset) moves the rq-lock a few lines up in scheduler_tick() to
> > also protect set_tsk_need_resched().
> > 
> > Is that neccessary?
> 
> scheduler_tick() is a special case,


> 'current' is pinned and cannot go 
> away, nor can it get off the runqueue.
Can you explain in short, why this is the case, please?
I don't really get behind it.
How are the two things enforced?

> So the patch is not needed. 
> 
>  Ingo

Thanks.

-- 
Regards Michael Buesch  [ http://www.tuxsoft.de.vu ]

Attachment: pgp00000.pgp
Description: PGP signature