Re: [PATCH 2.6] clean-up: fixes "shadows global", "unused parameter" warnings

From: Adrian Bunk
Date: Mon Dec 06 2004 - 16:42:12 EST


On Mon, Dec 06, 2004 at 10:55:11PM +0200, Riina Kikas wrote:
> This patch fixes warnings "declaration of `prefetch' shadows a global
> declaration"
> (occuring on line 141) and "unused parameter `addr'" (occuring on line 136)
>
> Signed-off-by: Riina Kikas <Riina.Kikas@xxxxxxx>
>
> --- a/arch/i386/mm/fault.c 2004-12-02 21:30:30.000000000 +0000
> +++ b/arch/i386/mm/fault.c 2004-12-02 21:30:59.000000000 +0000
> @@ -133,12 +133,12 @@
> * Sometimes AMD Athlon/Opteron CPUs report invalid exceptions on prefetch.
> * Check that here and ignore it.
> */
> -static int __is_prefetch(struct pt_regs *regs, unsigned long addr)
> +static int __is_prefetch(struct pt_regs *regs)
>...
> static inline int is_prefetch(struct pt_regs *regs, unsigned long

I wonder how this patch compiled for you considering that you didn't
change the call to __is_prefetch in is_prefetch...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/