Re: [PATCH] Fix ALSA resume

[Takashi Iwai]

At Sat, 4 Dec 2004 17:28:55 -0800,
Andrew Morton wrote:
> 
> But Joshua crosses his heart and swears that the pci_disable_device() is
> also needed for a successful swsusp resume.

Yes.  This would make suspend safer.

The linux-sound bk tree already includes the fix above and the patches
to add pci_disable_device() in appropriate places. 
Andrew, could you update bk-alsa patch set?


> Should snd_card_pci_suspend() be doing the pci_disable_device() as well, or
> it that a responsibility of the driver which called snd_card_pci_suspend()?

So far, we suppose that the lowlevel suspend() callback should call
pci_disable_device() although we can move it to the common place,
snd_card_pci_suspend().


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/