Re: [PATCH] Cyrix MII cpuid returns stale %ecx

From: H. Peter Anvin
Date: Fri Dec 03 2004 - 17:19:54 EST


Followup to: <20041203090843.GA25528@xxxxxxxxxxxxx>
By author: Andi Kleen <ak@xxxxxxx>
In newsgroup: linux.dev.kernel
>
> On Tue, Nov 30, 2004 at 10:07:55PM -0700, Zwane Mwaikambo wrote:
> > This patch is for the following bug, thanks to Ondrej Zary for
> > reporting, testing and submitting a patch.
> >
> > http://bugzilla.kernel.org/show_bug.cgi?id=3767
> >
> > It appears that the Cyrix MII won't touch %ecx at all resulting in stale
> > data being returned as extended attributes, so clear ecx before issuing
> > the cpuid. I have also made the capability print code display all the
> > capability words for easier debugging in future.
>
> Can you please change cpuid() on x86-64 too?
>
> I think it would be also better to not printk the capabilities
> at all or only with a special kernel option. Normally they are
> not needed, but they clutter up the boot log.
>

Since this is a bug fix for Cyrix MII, which isn't x86-64, it seems
pointless to do it for x86-64.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/