Re: [PATCH] handle quoted module parameters

[Rusty Russell]

On Sat, 2004-11-13 at 14:22 -0800, Randy.Dunlap wrote:
> yiding_wang@xxxxxxxxxxx wrote:
> >>There is *no* difference between:
> >>foo="111 222 333"\ 444' 555'
> >>and
> >>foo='111 222 333 444 555'
> >>and
> >>foo="111 222 333 444 555'
> > 
> > 
> > But there is a difference between foo="111 222 333" and "foo=111 222 333". The new patch is changing from former to later.
> 
> Actually the patch allows (or _should allow_) either format for quote
> marks.  I didn't remove the older code, just added support for the
> case of quote marks as "foo=this is a test".

Yes, I have no fundamental problem with the patch, but it'd need
thorough testing (eg. with __setup) since this area has broken before.

> Why is the module param length limit of 1024 a problem?

The 1024 test is there because we want to limit how much we output
through sysfs.  We could up it to PAGE_SIZE-1.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/