Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb

From: Yasushi SHOJI
Date: Sat Nov 13 2004 - 07:21:46 EST


Hi Linus,

At Mon, 8 Nov 2004 07:21:53 -0800 (PST),
Linus Torvalds wrote:
>
> On Mon, 8 Nov 2004, Antonino A. Daplas wrote:
> >
> > How about this patch? This is almost the original macro in riva_hw.h,
> > with the __force annotation.
>
> Why not just use __raw_readl/__raw_writel?
>
> That's what they exist for, and they still do any IO accesses correctly,
> which a direct store does not do (it would seriously break on older
> alphas, for example).

sorry for a dumb question but should readl/writel on big endian system
swap like ppc does?

hmm... checking source code, it seems like most arch indeed does that,
except m68knommu, h8300 and microblaze. is it nommu thing?
--
yashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/