Re: [Bonding-devel][PATCH]Zero Copy Transmit Support (Update)

From: Jay Vosburgh
Date: Fri Nov 12 2004 - 17:27:26 EST


David S. Miller <davem@xxxxxxxxxxxxx> wrote:
>That's definitely a good start.
>
>It does need to be fixed to enforce the usual rules about
>illegal combinations. And his code is going to include
>all sorts of weird things like VLAN offload which I wonder
>if works correctly with the current bonding driver? :)

The existing code should handle VLANs correctly, and the patch
excludes the VLAN related bits from the dev->features update.

>The two rules are codified in register_netdevice() as follows:
[...]

Would it be preferrable to duplicate that logic in bonding, or
push it out to an inline or some such?

-J

---
-Jay Vosburgh, IBM Linux Technology Center, fubar@xxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/