Re: [PATCH] remove explicit k_name use in atmel_cs.c, bt3c_cs.c

[Marcel Holtmann]

> diff -uprN -X /linux/dontdiff a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
> --- a/drivers/bluetooth/bt3c_cs.c	2004-08-26 22:05:15.000000000 +0200
> +++ b/drivers/bluetooth/bt3c_cs.c	2004-11-10 01:23:01.000000000 +0100
> @@ -489,13 +489,10 @@ static int bt3c_hci_ioctl(struct hci_dev
>  
>  static struct device *bt3c_device(void)
>  {
> -	static char *kobj_name = "bt3c";
> -
>  	static struct device dev = {
>  		.bus_id = "pcmcia",
>  	};
> -	dev.kobj.k_name = kmalloc(strlen(kobj_name) + 1, GFP_KERNEL);
> -	strcpy(dev.kobj.k_name, kobj_name);
> +	kobject_set_name(&dev.kobj, "bt3c");
>  	kobject_init(&dev.kobj);
>  
>  	return &dev;

The part for the bt3c_cs driver is fine with me and I have no problem if
Andrew picks this up and sends it to Linus for final inclusion. Once the
PCMCIA subsystem if fully integrated into the device model this will go
away anyway.

Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/