Re: [2.6 patch] kill IN_STRING_C
From: linux-os
Date: Tue Nov 09 2004 - 08:48:31 EST
On Tue, 9 Nov 2004, linux-os wrote:
On Tue, 9 Nov 2004, Adrian Bunk wrote:
On Mon, Nov 08, 2004 at 05:57:12PM -0500, linux-os wrote:
...
call strcpy
...
strcpy:
subl $8, %esp
...
It clearly invents strcpy, having never been referenced in the
source.
The asm code you sent does _not_ call a global strcpy function.
It calls an asm procedure named "strcpy" it ships itself.
BTW: You are the second person in this thread I have to explain this to...
Cheers,
Dick Johnson
cu
Adrian
Explain WHAT? There is NO strcpy in the code. No such procedure
should have been called. Period. The generated code is defective.
Here is more information showing the defective code generation.
Output of `nm`
00000000 r hello
U printk
00000039 t strcpy
00000000 T xxx
Clearly shows a strcpy symbol when strcpy() was never referenced
in the 'C' code.
Output of objdump
xxx.o: file format elf32-i386
Disassembly of section .text:
00000000 <xxx>:
0: 81 ec 0c 01 00 00 sub $0x10c,%esp
6: 89 9c 24 08 01 00 00 mov %ebx,0x108(%esp)
d: c7 44 24 04 00 00 00 movl $0x0,0x4(%esp)
14: 00
15: 8d 5c 24 08 lea 0x8(%esp),%ebx
19: 89 1c 24 mov %ebx,(%esp)
1c: e8 18 00 00 00 call 39 <strcpy>
21: 89 1c 24 mov %ebx,(%esp)
24: e8 fc ff ff ff call 25 <xxx+0x25>
29: 8b 9c 24 08 01 00 00 mov 0x108(%esp),%ebx
30: 31 c0 xor %eax,%eax
32: 81 c4 0c 01 00 00 add $0x10c,%esp
38: c3 ret
00000039 <strcpy>:
39: 83 ec 08 sub $0x8,%esp
3c: 8b 4c 24 0c mov 0xc(%esp),%ecx
40: 89 34 24 mov %esi,(%esp)
43: 89 7c 24 04 mov %edi,0x4(%esp)
47: 8b 74 24 10 mov 0x10(%esp),%esi
4b: 89 cf mov %ecx,%edi
4d: ac lods %ds:(%esi),%al
4e: aa stos %al,%es:(%edi)
4f: 84 c0 test %al,%al
51: 75 fa jne 4d <strcpy+0x14>
53: 89 c8 mov %ecx,%eax
55: 8b 34 24 mov (%esp),%esi
58: 8b 7c 24 04 mov 0x4(%esp),%edi
5c: 83 c4 08 add $0x8,%esp
5f: c3 ret
[SNIPPED...]
Clearly shows a GLOBAL procedure called strcpy when
no such procedure was ever referenced in the code.
Now I will show that the strcpy() procedure is NOT local.
It's global and can screw up anything:
Another program....
char printk; // Just quiet the reference
// ... just a label, never called.
extern int puts(const char *); // No header funnies
extern char *strcpy(char *, const char *);
int main(){
char buf[0x100];
strcpy(buf, "WTF?"); // Going to call it!
puts(buf);
return 0;
}
Show code generation.
$ gcc -S -o aaa zzz.c
.file "zzz.c"
.section .rodata
.LC0:
.string "WTF?"
.text
.globl main
.type main, @function
main:
pushl %ebp
movl %esp, %ebp
subl $264, %esp
andl $-16, %esp
movl $0, %eax
subl %eax, %esp
subl $8, %esp
pushl $.LC0
leal -264(%ebp), %eax
pushl %eax
call strcpy # Clearly calls it.
addl $16, %esp
subl $12, %esp
leal -264(%ebp), %eax
pushl %eax
call puts
addl $16, %esp
movl $0, %eax
leave
ret
.size main, .-main
.comm printk,1,1
.section .note.GNU-stack,"",@progbits
.ident "GCC: (GNU) 3.3.3 20040412 (Red Hat Linux 3.3.3-7)"
Now compile and link with the file containing ROGUE strcpy().
$ gcc -o zzz zzz.c xxx.o
$ ./zzz
WTF?
Executes, calling a ROGUE function that MUST NOT exist.
Cheers,
Dick Johnson
Penguin : Linux version 2.6.9 on an i686 machine (5537.79 BogoMips).
Notice : All mail here is now cached for review by John Ashcroft.
98.36% of all statistics are fiction.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/