Re: fbdev: fix compile of rivafb on __BIG_ENDIAN

From: Benjamin Herrenschmidt
Date: Mon Nov 08 2004 - 01:52:03 EST


On Mon, 2004-11-08 at 04:36 +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2606, 2004/11/07 20:36:41-08:00, torvalds@xxxxxxxxxxxxxxx
>
> fbdev: fix compile of rivafb on __BIG_ENDIAN
>
> Typo introduced by latest cleanups by Antonino
>
>
>
> riva_hw.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff -Nru a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
> --- a/drivers/video/riva/riva_hw.c 2004-11-07 22:05:40 -08:00
> +++ b/drivers/video/riva/riva_hw.c 2004-11-07 22:05:40 -08:00
> @@ -2112,7 +2112,7 @@
> #ifdef __BIG_ENDIAN
> /* turn on big endian register access */
> if(!(NV_RD32(chip->PMC, 0x00000004) & 0x01000001))
> - NV_WR32(chip->PMC, 0x00000004], 0x01000001);
> + NV_WR32(chip->PMC, 0x00000004, 0x01000001);
> #endif

Since the NV_* macros now use byteswapping readX/writeX, we probably
want to remove the above bits completely... I suspect as-is, the driver
no longer works on ppc, but then, I don't have nVidia HW to test any
more.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/